Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional light client metrics #6545

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Additional light client metrics #6545

merged 4 commits into from
Nov 15, 2024

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

Add some additional light client metrics plus one small bugfix to the get light client updates endpoint

@eserilev eserilev added light-client ready-for-review The code is ready for review labels Oct 28, 2024
dapplion
dapplion approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jimmygchen
jimmygchen requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the change looks good to me! Just a small nit on the metric name.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Nov 5, 2024
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 7, 2024
jimmygchen
jimmygchen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 7, 2024
@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Nov 7, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Nov 7, 2024
@mergify
Merge of #6545
ffb6f06
@mergify mergify bot mentioned this pull request Nov 7, 2024
Closed
5 tasks
@michaelsproul
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Nov 15, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Nov 15, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 654fc6a

mergify bot added a commit that referenced this pull request Nov 15, 2024
@mergify
Merge of #6545
c386981
@mergify mergify bot mentioned this pull request Nov 15, 2024
Closed
5 tasks
@mergify mergify bot merged commit 654fc6a into sigp:unstable Nov 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
light-client ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eserilev @jimmygchen @michaelsproul @dapplion