Increase jemalloc aarch64 page size limit (#5244) #6831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass JEMALLOC_SYS_WITH_LG_PAGE=16 to aarch64 cross-compilation to support systems with up to 64-KiB page sizes.
|
|
| # JEMALLOC_SYS_WITH_LG_PAGE=16 tells jemalloc to support up to 64-KiB | ||
| # pages, which are commonly used by aarch64 systems. | ||
| # See: https://github.com/sigp/lighthouse/issues/5244 | ||
| JEMALLOC_SYS_WITH_LG_PAGE=16 cross build --bin lighthouse --target aarch64-unknown-linux-gnu --features "portable,$(CROSS_FEATURES)" --profile "$(CROSS_PROFILE)" --locked |
There was a problem hiding this comment.
Can you please add the same to build-lcli-aarch64?
michaelsproul
added
under-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5244
Proposed Changes
Pass
JEMALLOC_SYS_WITH_LG_PAGE=16env to aarch64 cross-compilation to support systems with up to 64-KiB page sizes. This is backwards-compatible for the current (most usual) 4-KiB systems.