Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update I2S sample files: #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update I2S sample files: #16

wants to merge 2 commits into from

Conversation

waveletboy
Copy link

  1. Correct original BBC files to 2ch, 32bit, 16khz
  2. Add sample files for 2ch, 16bit, 48khz
  3. Fix the original issue on right channel for BBC files. Generated wav files can be played on both channels.
  4. Generate wav files for 2ch 16bit 48khz samples

Note: to generate correct wav file need to adjust functions wav_header() and wav_sample in pd.py in i2s decoder.

@waveletboy
Update I2S sample files:
225a8e6 
1. Correct original BBC files to 2ch, 32bit, 16khz
2. Add sample files for 2ch, 16bit, 48khz
3. Fix the original issue on right channel for BBC files. Generated wav files can be played on both channels.
4. Generate wav files for 2ch 16bit 48khz samples

Note: to generate correct wav file need to adjust functions wav_header() and wav_sample in pd.py in i2s decoder.
@waveletboy waveletboy mentioned this pull request Mar 20, 2020
Closed
@uwehermann
Copy link
Member

Hi, thanks for the PR! A few suggestions for changes:

  • Please drop the .wav files, only add .sr files to sigrok-dumps.

  • Please only use public domain audio files or files with explicitly mentioned free-ish license (PD, CC-BY or such). Also mention the source URL for the files as well as the license in the README.

A few random suggestions for public domain audio:
https://freesound.org/people/theojt/sounds/511195/
https://freesound.org/people/tnorr6969/sounds/511174/
https://freesound.org/people/theojt/sounds/510949/

(There are many other sources, of course)

The existing BBC file is very short, but we also don't have a clear license there AFAIK. Feel free to drop that one and replace it with only new files created by you, using free source material.

Thanks!

@waveletboy
Update I2S sample files:
23e53aa 
1. Remove original BBC files as unclear license.
2. Add sample files for 2ch, 16bit, 48khz from freesound
3. Generate wav files for 2ch 16bit 48khz samples

Note: to generate correct wav file need to adjust functions wav_header() and wav_sample in pd.py in i2s decoder.
@waveletboy
Copy link
Author

Hi Uwe,

I removed original BBC file and regenerate 2 sample files based on freesound.
However, I want to keep decoded wave files because they can help to understand the I2S->wav decoding. User can compare their decoding output with sample wav files. Please consider.

Thanks!

@waveletboy
Copy link
Author

Sorry for spamming here. Is second commit ok?

@uwehermann
Copy link
Member

Looks OK (will do some minor README cosmetics, but that's not a big deal), but please make the file snippets a lot smaller. Ideally < 1MB or 500kB or such per file. This makes sigrok-dumps and also sigrok-test (which will need updates as well) unnecessarily huge otherwise.

@r4d10n
Copy link

r4d10n commented Sep 30, 2021

Very useful example dumps to test decoding of I2S audio...

Using sigrok-cli and aplay, one can test live continuous decodes. Aplay can be used in RAW mode to ignore WAVE header inaccuracies.

sigrok-cli -i 2ch-16bit-48khz_01.sr -P i2s:sck=SCK:ws=WS:sd=SD -B i2s | aplay -t raw -f S16_LE -r 48000 -c 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@uwehermann uwehermann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waveletboy @uwehermann @r4d10n