adding tests case for ApplyTemplateOrReplace

Signed-off-by: Javan lacerda <[email protected]>

pkg/config/config.go

@@ -77,16 +77,16 @@ type FulcioConfig struct {
 type IssuerMetadata struct {
 	// Defaults contains key-value pairs that can be used for filling the templates from ExtensionTemplates
 	// If a key cannot be found on the token claims, the template will use the defaults
-	DefaultTemplateValues map[string]string
+	DefaultTemplateValues map[string]string `json:"DefaultTemplateValues,omitempty" yaml:"default-template-values,omitempty"`
 	// ExtensionTemplates contains a mapping between certificate extension and token claim
 	// Provide either strings following https://pkg.go.dev/text/template syntax,
 	// e.g "{{ .url }}/{{ .repository }}"
 	// or non-templated strings with token claim keys to be replaced,
 	// e.g "job_workflow_sha"
-	ExtensionTemplates certificate.Extensions
+	ExtensionTemplates certificate.Extensions `json:"ExtensionTemplates,omitempty" yaml:"extension-templates,omitempty"`
 	// Template for the Subject Alternative Name extension
 	// It's typically the same value as Build Signer URI
-	SubjectAlternativeNameTemplate string
+	SubjectAlternativeNameTemplate string `json:"SubjectAlternativeNameTemplate,omitempty" yaml:"subject-alternative-name-template,omitempty"`
 }
 
 type OIDCIssuer struct {

pkg/identity/ciprovider/principal_test.go

@@ -244,7 +244,31 @@ func TestApplyTemplateOrReplace(t *testing.T) {
 			ExpectedResult: "https://github.com/sigstore/fulcio/actions/runs/42/attempts/1",
 			ExpectErr:      false,
 		},
-		// Add more tests for edge cases
+		`Empty template`: {
+			Template:       "{{}}",
+			ExpectedResult: "",
+			ExpectErr:      true,
+		},
+		`Missing key for template`: {
+			Template:       "{{ .foo }}",
+			ExpectedResult: "",
+			ExpectErr:      true,
+		},
+		`Empty string`: {
+			Template:       "",
+			ExpectedResult: "",
+			ExpectErr:      true,
+		},
+		`Replaceable string`: {
+			Template:       "job_workflow_ref",
+			ExpectedResult: "sigstore/fulcio/.github/workflows/foo.yaml@refs/heads/main",
+			ExpectErr:      false,
+		},
+		`Missing string`: {
+			Template:       "bar",
+			ExpectedResult: "",
+			ExpectErr:      true,
+		},
 	}
 
 	for name, test := range tests {
@@ -254,9 +278,9 @@ func TestApplyTemplateOrReplace(t *testing.T) {
 				t.Errorf("expected result don't matches: Expected %s, received: %s",
 					test.ExpectedResult, res)
 			}
-			if (err == nil) == test.ExpectErr {
+			if (err != nil) != test.ExpectErr {
 				t.Errorf("should raise an error don't matches: Expected %v, received: %v",
-					test.ExpectErr, err)
+					test.ExpectErr, err != nil)
 			}
 		})
 	}