-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added footnote support and improve balancing logic for parallel typesetting. #2212
Conversation
Wow thanks for jumping in and contributing. I don't have time to give this a proper review this moment, but I certainly will. Just some preliminary feedback (and these are all things we can help fix and address, just FYI):
|
I just tried to fix some of the issues noted, but ran into one more thing: when you open PRs, it helps a lot if you start a new branch on your fork before opening the PR. That way you can allow us (maintainers) to contribute to the PR. As it is this is opened against your own forks master branch, which you cannot let us push to. I just pushed my modifications of your commits to this branch. You can reset your branch to the latest commit there, or run stylua and split up commits yourself, or close this PR and open one on a branch so I can just push directly to it, or whatever.... |
Thank you for guiding me on how to contribute to SILE. I didn't actually know what I was doing, after watching some YouTube guides and just trying things out. I will learn everything and follow the guidelines. Thank you for your time and instruction. Grateful as always. |
In case you are out there looking for this incantation, you can start a new branch from where you left off with this:
Then push and open a new PR from that branch, and I can help adjust it with some of the other work I did cleaning this up. |
You could read my mind, sir. I'm reading the Git Tutorial written by Dr. Yihsiang Liow and starting from scratch. I am so sorry for wasting too much of your time for such as trivial things, but grateful for your guidance. |
Introduced some features for footnote handling, improved frame alignment logic, and support for customisable glue and spacing.