Pragma #48
Merged
Pragma #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aolofsson
commented
May 6, 2024
•
aolofsson
commented
- Adding sync clear bit to fifo to enable graceful recovery
- Standardize around ifdef "SIM" for simulation only constructs
- Easier to remember for quick integration
- Different path from hardware reset - Enables graceful restart without having to hardware reset.
- Clear enough, shorter is better
gadfort
requested changes
May 6, 2024
| parameter PROP = "DEFAULT" | ||
| ) | ||
| module la_dsync #(parameter PROP = "DEFAULT", | ||
| parameter STAGES = 2, // synchronizer depth |
There was a problem hiding this comment.
how will this work with the pre-compiled technology libraries?
There was a problem hiding this comment.
Target libraries can have generate statements to select between different gate level netlists.
sgherbst
approved these changes
May 6, 2024
| @@ -1,16 +1,16 @@ | |||
| # Lambdalib Introduction | |||
|
|
|||
| Lambdalib is a modular hardware abstraction layer that helps decouple hardware design from manufacturing technology and proprietary IP. Lambdalib defines a set of technology independent generic functions that can be directly instantiated within the design. Technology specific implementations can be linked in at compile time. | |||
| Lambdalib is a modular hardware abstraction library decouples design from the uderlying manufacturing target. Lambdalib defines a set of generic functions that get resolved during the target technology mapping stage. | |||
There was a problem hiding this comment.
typos: that decouples, the underlying
| @@ -24,8 +24,8 @@ module la_spram #( | |||
| parameter DW = 32, // Memory width | |||
| parameter AW = 10, // Address width (derived) | |||
| parameter TYPE = "DEFAULT", // Pass through variable for hard macro | |||
| parameter CTRLW = 128, // Width of asic ctrl interface | |||
| parameter TESTW = 128 // Width of asic test interface | |||
| parameter CTRLW = 1, // Width of asic ctrl interface | |||
There was a problem hiding this comment.
I think this change will need to be synced with process-specific implementations of la_spram so that they can be interchanged
| (// basic interface | ||
| input clk, | ||
| input nreset,//async reset | ||
| input clear, //clear fifo statemachine (sync) |
There was a problem hiding this comment.
I think this interface change is pretty low-impact. But it still might be good to have some sort of announcement of interface and parameter default changes to the lambdalib users so that they know to update their RTL code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.