add ring cut notion to padring #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadfort
force-pushed
the
iocut
branch
2 times, most recently
from
d18cda3
to
86c57ed
Compare
aolofsson
requested changes
Aug 16, 2024
There was a problem hiding this comment.
Possibly just a documentation question, but we should have a clear definition of before and next. Lambdalib is genereric so we don't want to be prescriptive about ordering and methodology. As long as the definition is written down and consistent (in multiple places).
I think your definition "before and next" makes sense in the context of ioside and the 0/1 index is probably better than my left/rightedness (too prescriptive).
Can you add a few sentences in the README that explains the restrictoins/guidelines for usign la_iocut.
aolofsson
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64