Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove id-sync API and run the sync as a scheduled task #232

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Remove id-sync API and run the sync as a scheduled task #232

merged 5 commits into from
Nov 7, 2023

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 1, 2023

Removed

  • Removed id-sync ECS service
  • Removed id-sync load balancer target group and listener rule

Added

  • Added id-sync scheduled ECS task

@briskt briskt requested a review from a team November 1, 2023 19:40
@briskt briskt mentioned this pull request Nov 7, 2023
Merged
3 tasks
forevermatt
forevermatt approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor corrections/typos, but approved since they're easy fixes

terraform/070-id-sync/README.md Outdated Show resolved Hide resolved
terraform/070-id-sync/main.tf Outdated Show resolved Hide resolved
terraform/070-id-sync/main.tf Outdated Show resolved Hide resolved
@briskt briskt merged commit ca35239 into develop Nov 7, 2023
2 checks passed
@briskt briskt deleted the feature/remove-id-sync-api branch November 7, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @forevermatt