Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to route to transit gateway instead of NAT gateway. #236

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

BarnumD
Copy link

@BarnumD BarnumD commented Nov 28, 2023

No description provided.

Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, pending some small tweaks to the related terraform modules PR (possible variable rename, etc.).

@BarnumD
Copy link
Author

BarnumD commented Nov 29, 2023

Why are the checks failing?

@briskt
Copy link
Contributor

briskt commented Nov 30, 2023

Why are the checks failing?

It's failing on 070-id-sync because the test code references a new input that isn't present in the module. It's running the test code on the parent repo against the module in your fork. It should be resolved if you merge the latest from silinternational/idp-in-a-box into your fork.

@briskt briskt changed the base branch from develop to feature/tgw December 7, 2023 19:24
@briskt briskt merged commit 81c9010 into silinternational:feature/tgw Dec 7, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants