Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 12.8.1 -- fixed: avoid naming collisions #257

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Release 12.8.1 -- fixed: avoid naming collisions #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9855211
remove duplicate variable entry in email-service task definition
briskt Aug 28, 2024
ad18369
change the SNS topic name to avoid collision
briskt Aug 28, 2024
b8f5585
use idp_name instead of app_name to avoid naming collisions
briskt Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions terraform/031-email-service/task-definition-cron.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
"name": "APP_ID",
"value": "${appconfig_app_id}"
},
{
"name": "AWS_REGION",
"value": "${aws_region}"
},
{
"name": "ENV_ID",
"value": "${appconfig_env_id}"
Expand Down
3 changes: 2 additions & 1 deletion terraform/032-db-backup/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,12 @@ module "aws_backup" {
source = "silinternational/backup/aws"
version = "0.1.0"

app_name = var.app_name
app_name = var.idp_name
app_env = var.app_env
source_arns = [data.aws_db_instance.this.db_instance_arn]
backup_schedule = "cron(${var.aws_backup_cron_schedule})"
notification_events = var.aws_backup_notification_events
sns_topic_name = "${var.idp_name}-backup-vault-events"
}

data "aws_db_instance" "this" {
Expand Down
Loading