Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 12.11.1 -- add check on cloudflare_domain to avoid plan fail #269

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Release 12.11.1 -- add check on cloudflare_domain to avoid plan fail #269

merged 1 commit into from
Oct 30, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Oct 30, 2024

Fixed

  • Bypass creation of the cloudflare_ruleset if cloudflare_domain isn't specified.

@briskt briskt requested a review from a team as a code owner October 30, 2024 01:53
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team October 30, 2024 01:53
@briskt briskt changed the title add check on cloudflare_domain to avoid plan fail Release 12.11.1 -- add check on cloudflare_domain to avoid plan fail Oct 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit c83b1ee into main Oct 30, 2024
3 checks passed
@briskt briskt deleted the check-cloudflare-domain branch October 30, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/tf-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/tf-devs

@Praveenraj-K Praveenraj-K Awaiting requested review from Praveenraj-K Praveenraj-K is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics