Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 12.11.2 -- add IdP name to WAF rule #270

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Release 12.11.2 -- add IdP name to WAF rule #270

merged 1 commit into from
Oct 30, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Oct 30, 2024

Fixed

  • Try adding the IdP name to the WAF rule to avoid error message: "A similar configuration with rules already exists and overwriting will have unintended consequences."

@briskt
try adding the idp name to the WAF rule to avoid error message
c5b7c5e 
"A similar configuration with rules already exists and overwriting will have unintended consequences. "
@briskt briskt requested a review from a team as a code owner October 30, 2024 06:19
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team October 30, 2024 06:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics approved these changes Oct 30, 2024
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it avoids the error

@briskt briskt merged commit ac094c7 into main Oct 30, 2024
3 checks passed
@briskt briskt deleted the name-waf-rule branch October 30, 2024 07:22
@briskt
Copy link
Contributor Author

briskt commented Oct 30, 2024

Hope it avoids the error

Me too. I doubt it will, but I had to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/tf-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/tf-devs

@Praveenraj-K Praveenraj-K Awaiting requested review from Praveenraj-K Praveenraj-K is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics