Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the Cloudflare WAF rule #273

Merged
merged 1 commit into from
Nov 12, 2024
Merged

remove the Cloudflare WAF rule #273

merged 1 commit into from
Nov 12, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 11, 2024

Removed

  • Removed the Cloudflare WAF rule created for the Super Bot Fight mode. Terraform failed to create multiple similar WAF rules when more than one IdP came into play. We now create this at the AWS account level.

@briskt
remove the Cloudflare WAF rule
6889de5 
Terraform failed to create multiple similar WAF rules when more than one IdP came into play.
@briskt briskt requested a review from a team as a code owner November 11, 2024 11:31
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team November 11, 2024 11:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit 68c8c94 into main Nov 12, 2024
3 checks passed
@briskt briskt deleted the rm-cloudflare-rule branch November 12, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/tf-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/tf-devs

@Praveenraj-K Praveenraj-K Awaiting requested review from Praveenraj-K Praveenraj-K is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @jason-jackson