Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues found by tflint #275

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix issues found by tflint #275

merged 1 commit into from
Nov 21, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 21, 2024

ITSE-1618 Add tflint to Terraform workflow


Added

  • Added type on all variables that didn't already have it.

Fixed

  • In the 030-phymyadmin module, connected the cpu and memory variables to the phpmyadmin module.

Removed

  • Removed unused variables and data elements

@briskt briskt requested a review from a team as a code owner November 21, 2024 07:30
@briskt briskt requested review from forevermatt, jason-jackson, hobbitronics and Praveenraj-K and removed request for a team November 21, 2024 07:30
@briskt briskt merged commit aff6cc5 into main Nov 21, 2024
2 checks passed
@briskt briskt deleted the lint-fixes branch November 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants