Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable detailed monitoring #278

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Option to disable detailed monitoring #278

merged 7 commits into from
Dec 9, 2024

Conversation

Praveenraj-K
Copy link
Contributor

@Praveenraj-K Praveenraj-K commented Dec 9, 2024 •
edited by briskt
Loading

Added

  • Changed the asg module to add the option to disable EC2 detailed monitoring

@Praveenraj-K Praveenraj-K requested a review from a team as a code owner December 9, 2024 06:38
@Praveenraj-K Praveenraj-K requested review from briskt, forevermatt, jason-jackson and hobbitronics and removed request for a team December 9, 2024 06:38
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

briskt
briskt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the title is wrong. It's not adding detailed monitoring, it's disabling it.

briskt
briskt requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default should be true

@Praveenraj-K Praveenraj-K changed the title Added detailed monitoring Disabled detailed monitoring Dec 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt changed the title Disabled detailed monitoring Option to disable detailed monitoring Dec 9, 2024
@Praveenraj-K Praveenraj-K merged commit 351729d into main Dec 9, 2024
3 checks passed
@Praveenraj-K Praveenraj-K deleted the feature-monitoring branch December 9, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/tf-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/tf-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/tf-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Praveenraj-K @briskt