Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.7.0 -- add a new variable to assign tags to the ASG #13

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Release 0.7.0 -- add a new variable to assign tags to the ASG #13

merged 1 commit into from
Aug 27, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Aug 27, 2024 •
edited
Loading

ITSE-733 Add missing tags to AWS objects

Added

  • Added a new variable, asg_tags, to assign tags to the autoscaling group and EC2 instances.

@briskt briskt requested a review from a team August 27, 2024 12:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dalenewby
dalenewby approved these changes Aug 27, 2024
View reviewed changes
Copy link

@dalenewby dalenewby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to document the new variable somewhere?

@briskt
Copy link
Contributor Author

briskt commented Aug 27, 2024

Do we need to document the new variable somewhere?

Terraform registry does that for us.

@briskt briskt merged commit 1cfbc6a into main Aug 27, 2024
2 checks passed
@briskt briskt deleted the asg-tags branch August 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalenewby dalenewby dalenewby approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @dalenewby