Word Export: Prevent extra Before/After content for senses #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When senses are in separate paragraphs we were still adding the before and after content that was around the collection of senses. It is now only added when not in separate paragraphs. Change-Id: I89dc3703a42b22455ac41a8420cc0ac66a9ffc30
JakeOliver28
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mark-sil)
Src/xWorks/LcmWordGenerator.cs line 1638 at r1 (raw file):
bool eachInAParagraph = config != null && config.DictionaryNodeOptions is DictionaryNodeSenseOptions && ((DictionaryNodeSenseOptions)(config.DictionaryNodeOptions)).DisplayEachSenseInAParagraph;
Would this be clearer/more concise?
Code snippet:
var senseOptions = config?.DictionaryNodeOptions as DictionaryNodeSenseOptions;
bool eachInAParagraph = senseOptions?.DisplayEachSenseInAParagraph ?? false;
|
closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When senses are in separate paragraphs we were still adding the before and after content that was around the collection of senses. It is now only added when not in separate paragraphs.
This change is