Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word Export LT-21768: Add Bullets and Numbering #168

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Sep 25, 2024

A remaining task is to support font properties on the bullet or number characters.


This change is Reviewable

A remaining task is to support font properties on the bullet
or number characters.

Change-Id: I8416ebf88b66e70b12d53b7136e511cbfc19476f
@jasonleenaylor
Copy link
Contributor

Src/xWorks/LcmWordGenerator.cs line 2501 at r1 (raw file):

			var abstractNum = new AbstractNum(abstractLevel) { AbstractNumberId = bulletUniqueId };
			var lastAbstractNum = numberingPart.Numbering.Elements<AbstractNum>().LastOrDefault();
			if (lastAbstractNum == null)

A comment to explain this would be good. I see that you are adding it after the last list item that is AbstractNum, or at the end. I just don't quite understand why.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

mark-sil and others added 3 commits September 26, 2024 08:11
A remaining task is to support font properties on the bullet
or number characters.

Change-Id: I91f82e06ecd7546d3cbeae6c374fd250cd0c7775
Merge commit 'refs/pull/168/head' of
https://github.com/sillsdev/FieldWorks into LT-21768

Change-Id: I026c56bcfba574b8f506ab476160b17e12cd8555
@mark-sil
Copy link
Contributor Author

Src/xWorks/LcmWordGenerator.cs line 2501 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

A comment to explain this would be good. I see that you are adding it after the last list item that is AbstractNum, or at the end. I just don't quite understand why.

Done.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

@mark-sil mark-sil merged commit df3fada into release/9.1 Sep 26, 2024
5 checks passed
@mark-sil mark-sil deleted the LT-21768 branch September 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants