Enable/Disable analytics based on user consent

[andracc]

Resolves #3410

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 49.05660% with 27 lines in your changes missing coverage. Please review.

Project coverage is 74.61%. Comparing base (cf6d1eb) to head (a4c4592).

Files with missing lines	Patch %	Lines
Backend/Otel/OtelKernel.cs	52.17%	0 Missing and 11 partials ⚠️
...c/components/AnalyticsConsent/AnalyticsConsent.tsx	0.00%	10 Missing ⚠️
src/components/App/AppLoggedIn.tsx	0.00%	4 Missing ⚠️
src/components/UserSettings/UserSettings.tsx	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
- Coverage   74.71%   74.61%   -0.11%     
==========================================
  Files         285      286       +1     
  Lines       10996    11033      +37     
  Branches     1337     1344       +7     
==========================================
+ Hits         8216     8232      +16     
- Misses       2398     2416      +18     
- Partials      382      385       +3     

Flag	Coverage Δ
backend	83.93% <66.66%> (+0.21%)	⬆️
frontend	66.30% <20.00%> (-0.41%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[imnasnainaec]

Reviewed 5 of 12 files at r2, all commit messages.
Reviewable status: 5 of 12 files reviewed, 7 unresolved discussions (waiting on @andracc)

---

Backend/Models/User.cs line 69 at r2 (raw file):

        public string Username { get; set; }

        [BsonElement("otelConsent")]

Let's add /// <summary> comments for these two consent bools, since it might be confusing what the difference is.

---

Backend.Tests/Otel/OtelKernelTests.cs line 40 at r2 (raw file):

        [Test]
        public void BuildersSetConsentAndSessionBaggageFromHeader()

How about just BuildersSetBaggageFromHeader (and OnEndSetsTagsFromBaggage below)?

---

Backend/Otel/OtelKernel.cs line 108 at r2 (raw file):

            public override async void OnEnd(Activity data)
            {
                var consentString = data?.GetBaggageItem("otelConsentBaggage");

Why is the ? necessary on data? throughout this function?

---

src/components/UserSettings/UserSettings.tsx line 82 at r2 (raw file):

  const show = (): void => setDisplayConsent(true);

  const handleConsentChange = (consentVal: boolean | undefined): void => {

This can be shortened to consentVal?: boolean

---

src/components/UserSettings/UserSettings.tsx line 303 at r2 (raw file):

                    data-testid={UserSettingsIds.ButtonChangeConsent}
                    id={UserSettingsIds.ButtonChangeConsent}
                    onClick={show}

Since show isn't used elsewhere, we can just use a lambda function here:

onClick={() => setDisplayConsent(true)}

---

src/backend/index.ts line 60 at r2 (raw file):

    ? ((config.headers.otelConsent = true),
      (config.headers.sessionId = getSessionId()))
    : (config.headers.otelConsent = false);

This <...> ? ((<do one thing>), (<do another thing>)) : (<...>) notation is compact and logically correct, but the presence of an ordered pair ((...), (...)) could be confusing. How about a slightly longer, more common and explicit

  if (LocalStorage.getCurrentUser()?.otelConsent) {
    config.headers.otelConsent = true;
    config.headers.sessionId = getSessionId();
  } else {
    config.headers.otelConsent = false;
  }

---

src/components/AnalyticsConsent/AnalyticsConsent.tsx line 0 at r2 (raw file):
If this file is changed to src/components/AnalyticsConsent/index.tsx and export function changed to export default function, then that will match our style elsewhere, and it can be imported with

import AnalyticsConsent from "components/AnalyticsConsent";

rather than

import { AnalyticsConsent } from "components/AnalyticsConsent/AnalyticsConsent";

---

src/components/AnalyticsConsent/AnalyticsConsent.tsx line 45 at r2 (raw file):

              <Typography
                variant="h6"
                style={{ color: "#1976d2", fontWeight: 600 }}

Use color: themeColors.primary rather than using a hex code here.

---

src/components/AnalyticsConsent/AnalyticsConsent.tsx line 46 at r2 (raw file):

                variant="h6"
                style={{ color: "#1976d2", fontWeight: 600 }}
                color="primary"

This color="primary" is unnecessary, being overridden by the manual color definition in the style.

---

src/components/AnalyticsConsent/AnalyticsConsent.tsx line 70 at r2 (raw file):

              <Grid item>
                <Button
                  color="primary"

The color="primary" and this and the next button are unnecessary because "primary" is the default color.

---

src/components/AnalyticsConsent/AnalyticsConsent.tsx line 72 at r2 (raw file):

                  color="primary"
                  onClick={acceptAnalytics}
                  style={{

These button dimensions may be too small for some ui languages, so let's bump up to

style={{ height: 60, width: 155 }}

in both these buttons.

---

src/components/App/AppLoggedIn.tsx line 58 at r2 (raw file):

  async function handleConsentChange(
    otelConsent: boolean | undefined

This can be shortened to otelConsent?: boolean.

---

src/components/App/AppLoggedIn.tsx line 107 at r2 (raw file):

              onChangeConsent={handleConsentChange}
              required
            ></AnalyticsConsent>

This can be shortened to

<AnalyticsConsent onChangeConsent={handleConsentChange} required />