Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused vanilla-cookieconsent #3535

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Remove unused vanilla-cookieconsent #3535

merged 5 commits into from
Jan 24, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 24, 2025

Follow-up to #3467


This change is Reviewable

@imnasnainaec imnasnainaec added frontend dependencies Pull requests that update a dependency file labels Jan 24, 2025
@imnasnainaec imnasnainaec self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.61%. Comparing base (b1db050) to head (04b362e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
+ Coverage   74.56%   74.61%   +0.04%     
==========================================
  Files         285      285              
  Lines       11032    11032              
  Branches     1341     1341              
==========================================
+ Hits         8226     8231       +5     
+ Misses       2423     2419       -4     
+ Partials      383      382       -1     
Flag Coverage Δ
backend 83.93% <ø> (+0.09%) ⬆️
frontend 66.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from andracc January 24, 2025 16:54
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 24, 2025 22:30
@imnasnainaec imnasnainaec merged commit 6946b24 into master Jan 24, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the nix-vanilla-cc branch January 24, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants