Make headword and other utils writing-system aware #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI unit Tests12 tests 12 ✅ 0s ⏱️ Results for commit 85f6063. ♻️ This comment has been updated with latest results. |
C# Unit Tests104 tests 104 ✅ 5s ⏱️ Results for commit 85f6063. ♻️ This comment has been updated with latest results. |
hahn-kev
reviewed
Jan 21, 2025
hahn-kev
reviewed
Jan 21, 2025
hahn-kev
reviewed
Jan 21, 2025
hahn-kev
reviewed
Jan 21, 2025
hahn-kev
reviewed
Jan 21, 2025
hahn-kev
requested changes
Jan 21, 2025
myieye
force-pushed
the
make-entry-and-multi-string-utils-writing-system-aware
branch
from
02f4dee to
85f6063
Compare
myieye
deleted the
make-entry-and-multi-string-utils-writing-system-aware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves utils like
headwordandpickBestAlternativeinto a newWritingSystemServiceclass, so that the utils are "writing-system aware" and can make more accurate choices based on the project's current writing-system configuration.