prevent reference cycles in complex forms

[hahn-kev]

this will avoid issues syncing with Fw where lcm will throw if you attempt to make a reference cycle

[github-actions]

C# Unit Tests

104 tests   104 ✅  5s ⏱️
 16 suites    0 💤
  1 files      0 ❌

Results for commit da576bc.

♻️ This comment has been updated with latest results.

[myieye]

LGTM! Very elegant algorithm. 🤓
I suppose we should figure out how to bubble this up to the UI if it actually happens while working in the app. Otherwise, nothing will happen and there will be no explanation as to why not. Though fortunately for the activity view you should be able to figure it out somewhat easily.

[myieye]

Actually, there's a problem: deleted Components seem to still get used when looking for cycles. That's just what I'm observing as I try it.
I'm guessing that should be solved upstream? I.e. Harmony shouldn't return deleted objects?

[hahn-kev]

yeah we should ignore them here. But no I don't think we should change harmony we just need to take that into account, though there's an argument for having that be a filter parameter which defaults to false which is what we usually want.