Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and validation fixups #1407

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Jan 23, 2025

I was playing with importing and updating various projects and found these changes to be valuable.

  • Turning off the Pos.Name validation is something @hahn-kev suggested a while ago. It's blocking a few real projects I've played with locally.
  • I see the catch in FromLexEntry(ILexEntry entry) trigger when entry.ComplexFormEntryRefs.SingleOrDefault() finds multiple items. We haven't decided what to do about that, but it's nice to at least see which entry is causing the problem. By doing so, I could modify the fwdata file to make the import happy. Deleting the entry refs in the UI didn't really help 🙃.
  • The try catch in LexEntryHeadword(entry) is maybe excessive. It just felt good, beacuse I'm calling it from a catch block.
  • I ran into other validation errors that didn't provide enough context for me to troubleshoot. Especially when we're complaining that something is null or empty, well....what is it?! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant