Corpora fixes

[johnml1135]

Addresses

• Corpus endpoint should return name #594 name not being stored with corpus
• GET /corpora API call doesn't return newly created corpus #595 GetAllCorpuses is not returning anything!
• Create corpus with an empty language specifier should fail #596 corpus with empty language should fail
• Adds integration tests for the corpus
• Propagates deleted file to the corpus (propagating update not needed, because the filename is not stored).

---

This change is 

[Enkidu93]

Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @johnml1135)

---

src/Serval/test/Serval.ApiServer.IntegrationTests/DataCorporaTests.cs line 5 at r1 (raw file):

[TestFixture]
[Category("Integration")]
public class DataCorporaTests

Maybe just CorporaTests? Why DataCorporaTests? I guess it's TranslationEngineTests not EngineTests, but it's also justDataFileTests and WebhookTests.

---

src/Serval/src/Serval.DataFiles/Controllers/CorporaController.cs line 160 at r1 (raw file):

    private async Task<Corpus> MapAsync(CorpusConfigDto corpusConfig, string id, CancellationToken cancellationToken)
    {
        if (corpusConfig.Language == null || corpusConfig.Language.Length == 0)

Isn't Language a required property? So is it necessary to check it for null?

[johnml1135]

src/Serval/src/Serval.DataFiles/Controllers/CorporaController.cs line 160 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

Isn't Language a required property? So is it necessary to check it for null?

True.

[johnml1135]

src/Serval/test/Serval.ApiServer.IntegrationTests/DataCorporaTests.cs line 5 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

Maybe just CorporaTests? Why DataCorporaTests? I guess it's TranslationEngineTests not EngineTests, but it's also justDataFileTests and WebhookTests.

Agree

[Enkidu93]

Reviewed 1 of 2 files at r2.
Reviewable status: 5 of 6 files reviewed, all discussions resolved

---

src/Serval/test/Serval.ApiServer.IntegrationTests/DataCorporaTests.cs line 5 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Agree

I am realizing now that some of the tests have plurals (e.g., Webhooks, Corpora) and other have singulars (e.g. TranslationEngine, WordAlignmentEngine). Maybe we should clean that up at some point.

[johnml1135]

src/Serval/test/Serval.ApiServer.IntegrationTests/DataCorporaTests.cs line 5 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

I am realizing now that some of the tests have plurals (e.g., Webhooks, Corpora) and other have singulars (e.g. TranslationEngine, WordAlignmentEngine). Maybe we should clean that up at some point.

Maybe.