Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash if retrieving a corpora with a blank language code #600

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Jan 13, 2025

Further fix for #595


This change is Reviewable

@johnml1135 johnml1135 requested a review from Enkidu93 January 13, 2025 14:53
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit a4203cf into main Jan 13, 2025
3 checks passed
@johnml1135 johnml1135 deleted the fix_empy_language branch January 13, 2025 15:03
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.48%. Comparing base (f45b102) to head (f288bdb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Serval.DataFiles/Controllers/CorporaController.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   64.48%   64.48%           
=======================================
  Files         280      280           
  Lines       14105    14105           
  Branches     1825     1825           
=======================================
  Hits         9095     9095           
  Misses       4349     4349           
  Partials      661      661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants