USFM preservation for paragraph and character markers #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move attention-based method
ddaspit
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
This is excellent work (uses existing shared code where possible, sticks to the conventions of the codebase, uses proper typing for clarity).
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @isaac091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few notes:
--include-inline-elements,--preserve-usfm-markers, and any hard-coded names/lists of markers will be replaced by whatever customization system we end up implementingParagraphUpdateUsfmParserHandlerandUsfmPreservercode should be moved to machine.py.usfm_utils.pyis not necessary for the rest of the code, it's just a little script I wrote for David to make it easier to find good project pair candidates for testing. It doesn't need to be merged if it's clutter.Towards #560
This change is