SF-3068 Update BT offline message #2935
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebuss
added
the
will require testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2935 +/- ##
==========================================
- Coverage 80.91% 80.91% -0.01%
==========================================
Files 533 533
Lines 31263 31263
Branches 5062 5079 +17
==========================================
- Hits 25298 25297 -1
+ Misses 5218 5206 -12
- Partials 747 760 +13 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Please update the acceptance tests on this issue so the testers know what to look for.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kylebuss)
kylebuss
commented
Jan 8, 2025
There was a problem hiding this comment.
Done.
Reviewable status:
RaymondLuong3
force-pushed
the
fix/sf-3068
branch
from
61789d3 to
6fe4619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the confusion of the offline message that is shown for BT that was found during regression testing.
This change is