Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-3149 Only update resource permissions when necessary #2938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 8, 2025

This PR speeds up synchronizing of popular resources on live by:

  • Only updating the permissions for users in the target project when a resource is a source to a project.
  • Updating all permissions on a resource when the DBL has flagged that the resource has been updated.

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (bee4856) to head (998e10e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2938   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files         533      533           
  Lines       31260    31261    +1     
  Branches     5079     5063   -16     
=======================================
+ Hits        25294    25296    +2     
- Misses       5206     5218   +12     
+ Partials      760      747   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will require testing PR should not be merged until testers confirm testing is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants