chore: run demo https tunneled from localhost #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontrollanten
force-pushed
the
feat-kontrollanten-demo
branch
from
15c2fe4
to
79825b9
Compare
kontrollanten
force-pushed
the
feat-kontrollanten-demo
branch
from
c371757
to
75fd18e
Compare
kontrollanten
force-pushed
the
feat-kontrollanten-demo
branch
2 times, most recently
from
9bb77d6
to
d56a663
Compare
To be able to actually run the demo it needs to be served behind a server with a valid HTTPS certificate. In order to simplify this, and make it easier to verify and develop this library, a npm script is added to setup the demo behind a HTTPS server in a single command.
Add watch command to simplify development.
Extend the demo to support: * Switching between videojs versions 6, 7 and 8. * Switching between HLS and regular mp4 files.
kontrollanten
force-pushed
the
feat-kontrollanten-demo
branch
from
d56a663
to
bb29aaf
Compare
|
Hi @onebytegone Do you have any comments on this? I think it's quite a low risk PR since it doesn't affect the existing code. I hope this PR will make it easier for new people to try this package, but also for contributors to test the functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to actually run the demo it needs to be served behind a server with a valid HTTPS certificate. In order to simplify this, and make it easier to verify and develop this library, a npm script is added to setup the demo behind a HTTPS server in a single command.
A side note:
Is it necessary to pin the dependencies in package.json since package-lock.json is introduced?
Update
Added support for: