Upgrade to node 20.12.22 & grunt-contrib-uglify to 5.2.2 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 7, 2024 17:09
Updates the .nvmrc to point node version 20.12.2
Creates the necessary scripts to support commands that will be exeucted during the build
The [email protected] package would break because Babel no longer removes `const` based on our configurations and how they interact with the latest browserslist output. However, [email protected] or later does not break when it sees `const`. So, we can update to the latest version, 5.2.2.
This was necessary due to the update to the version of grunt-contrib-uglify.
Uglify was configured to mangle/compress in debug mode and beautify mode in production.This should be reversed.
The CI steps need to be updated to use Node 20. While doing so, we incorporated some additional work: - Update all actions to use the latest versions that run on Node 20 - Update the test matrix to use our .nvmrc file as one of the Node versions to test againsts - Check for uncommitted changes after installing dependencies
Timodie
changed the title
kmuncie
reviewed
Aug 8, 2024
There was a problem hiding this comment.
Just a first pass review, @joshuacurtiss can take it from here
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/checkout@v4 |
| name: Put NVM version in output | ||
| id: makeNodeVersionOutput | ||
| run: echo "nvmrc=$(cat .nvmrc)" >> "$GITHUB_OUTPUT" | ||
|
|
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm i -g [email protected] | ||
| - run: npm ci # Reinstall the dependencies to ensure they install with the current version of node | ||
| - run: npm test |
There was a problem hiding this comment.
Should we be running the following before npm test?
- run: npm run standards
- run: npm run build # Ensure building is possible with this version of node
| @@ -1 +1 @@ | |||
| 16.15.0 | |||
| 20.12.2 | |||
There was a problem hiding this comment.
I believe we are standardizing on including the v here
| @@ -5,15 +5,18 @@ | |||
| "main": "src/js/index.js", | |||
| "scripts": { | |||
| "commitlint": "commitlint --from 5ed6165", | |||
| "test": "check-node-version --npm 8.5.5 && nyc mocha -- -R spec 'tests/**/*.test.js'", | |||
| "check-node-version": "check-node-version --node $(cat .nvmrc) --npm 10.5.0 --print", | |||
| "test": "nyc mocha -- -R spec 'tests/**/*.test.js'", | |||
There was a problem hiding this comment.
I don't see the -R "reporter" option configured in many other projects. I know it was here before, but should it continue to be included?
There was a problem hiding this comment.
It looks like -R spec is default behavior for this and future versions of mocha, so it is safe to omit.
|
I concur with @kmuncie, and may I add a few more points?
|
Merged
|
Please reference #179. |
|
Superseded by #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a similar fashion to silvermine/videojs-airplay#54, this PR upgrades the repo node 20.12.22 and also upgrades
"grunt-contrib-uglifyto5.2.2