Bug fix - str replacement with forward slash #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when href="/", value of $link is forward slash symbol. All forward slashes in HTML like </p> will be replaced with tracking link and layout will be broken. Should search and replace '"/"'.
|
Could this problem also appear elsewhere? Could /about-us and /about-us/staff end up replacing one another? I suggest a better solution to this is to ensure that the replacement mechanism always replaces quoted strings, rather than just in this one condition. |
|
Test cases please :) |
|
@tractorcow Yeah that may happen in that case, but I am not sure. A simple test case: add couple paragraphs, insert HomePage (URL segment must be '/') hyperlink, then add some more links. |
|
My debug logs. http://shrib.com/7l5sHpeU |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when href="/", value of $link is forward slash symbol. All forward slashes in HTML like
will be replaced with tracking link and layout will be broken. Should search and replace '"/"'.