Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Change default value of doclinting #113

Closed
wants to merge 1 commit into from
Closed

DOC Change default value of doclinting #113

wants to merge 1 commit into from

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Apr 10, 2024
Closed
GuySartorelli
GuySartorelli approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GuySartorelli
GuySartorelli requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to actually update the default in ci.yml

@emteknetnz
Copy link
Member Author

LOL. No I'm confusing myself, don't need this PR. It should be true in ci.yml.

Setting to false would mean "don't create a doclinting job even if there's a .doclintrc file"

@emteknetnz emteknetnz closed this Apr 10, 2024
@GuySartorelli GuySartorelli deleted the pulls/1.8/change-default branch April 10, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli