Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Sometimes modules get tagged when there's no actual code change #6

Closed
GuySartorelli opened this issue Aug 29, 2023 · 1 comment
Closed
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 29, 2023

Sometimes, a release is being made even when there's no code change, e.g. https://github.com/silverstripe/silverstripe-framework/releases/tag/5.0.20 -- actual code diff - https://github.com/silverstripe/silverstripe-framework/compare/5.0.19..5.0.20

The scenarios that can cause this are:

  1. A change is made in 5.0 and tagged, and then backported to 4.13, and merged back up to 5.0 - this will get auto-tagged again but this second tag in 5.0 won't have any actual code change.
  2. A change will be made in CMS 4 that we don't want to keep in CMS 5, so it's reverted in the merge up. Again, this will be auto-tagged with no code change.

Acceptance criteria

  • patches aren't tagged if there's no change since the last tag.

notes

  • we could explicitly check if the code changes in the diff come from one of the commits that contributes to this being worth tagging (i.e validate that the code changes don't belong only to MNT commits), but that's likely overkill.

PRs

@GuySartorelli
Copy link
Member Author

PR merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants