ENH Check if there are no actual changes to release

[emteknetnz]

Issue #6

Example of it still releasing:

• https://github.com/emteknetnz/silverstripe-contentreview/actions/runs/6020168590/job/16331355224

Example of it not releasing because identical:

• https://github.com/emteknetnz/silverstripe-contentreview/actions/runs/6020457051/job/16331918294

[GuySartorelli]

Why are we counting these separately, instead of explicitly checking for the entire "<strong>$LATEST_TAG</strong> and <strong>$GITHUB_SHA</strong> are identical."?

[emteknetnz]

Because there's a line break in between them with a load of leading spaces for the second string

[GuySartorelli]

I think this is too flimsy. They could add or remove whitespace at any time without affecting the way it renders in the browser - or change the HTML tags they're using (<strong> could swap out for a <span> with some css classes to handle the bold, for example). Might be better to do a quick php -a with strip_tags and do a whitespace-agnostic regex.

[GuySartorelli]

I think this is too flimsy. They could add or remove whitespace at any time without affecting the way it renders in the browser - or change the HTML tags they're using (<strong> could swap out for a <span> with some css classes to handle the bold, for example). Might be better to do a quick php -a with strip_tags and do a whitespace-agnostic regex.

[emteknetnz]

@GuySartorelli updated

Test run works as expected with code changes - https://github.com/emteknetnz/silverstripe-contentreview/actions/runs/6032187219/job/16367088876

[GuySartorelli]

Looks good to me.