Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Init array, use $oldName, add REPOS_EXCLUDE, check if label exists before rename #30

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 28, 2024

Issue silverstripe/.github#154

Need to init the array to prevent an error if no repos were matched using --only / --exclude falgs

Use $oldName so that the correct URL is used when rewriting an old label

Add REPOS_EXCLUDE which has some repos that should never have their labels updated

@emteknetnz emteknetnz changed the title FIX Init array and use $oldName FIX Init array, use $oldName, add REPOS_EXCLUDE Jan 28, 2024
@emteknetnz emteknetnz changed the title FIX Init array, use $oldName, add REPOS_EXCLUDE FIX Init array, use $oldName, add REPOS_EXCLUDE, check if label exists before rename Jan 28, 2024
@emteknetnz emteknetnz force-pushed the pulls/main/array branch 5 times, most recently from cdbc85f to f242581 Compare January 28, 2024 23:40
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very small changes.
Also needs rebase.

labels_command.php Outdated Show resolved Hide resolved
labels_command.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/main/array branch 2 times, most recently from d53bdf1 to cbc6c08 Compare January 29, 2024 01:00
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 37fee74 into silverstripe:main Jan 29, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/array branch January 29, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants