Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Only write file if it is different #8

Merged
merged 1 commit into from
Aug 17, 2023
Merged

ENH Only write file if it is different #8

merged 1 commit into from
Aug 17, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 15, 2023 •
edited
Loading

Issue #7

@GuySartorelli GuySartorelli mentioned this pull request Aug 15, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ignore the edge case of trying to write an empty file, since that seems like something we won't ever want to do any this isn't meant to be used by anyone else.

Looks good.

@GuySartorelli GuySartorelli merged commit 17e8cf1 into silverstripe:main Aug 17, 2023
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/file-write branch August 17, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli