Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove TODO comments #283

Merged
merged 1 commit into from
Oct 29, 2023
Merged

MNT Remove TODO comments #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/src/containers/CampaignAdmin/CampaignAdmin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ class CampaignAdmin extends Component {
// NOOP - Lazy loaded in CampaignAdminList.js
break;
case 'edit':
// @todo - Lazy load in FormBuilderLoader / GridField
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
breadcrumbs.push({
text: title,
href: this.getActionRoute(id, view),
Expand Down
2 changes: 0 additions & 2 deletions client/src/containers/CampaignAdmin/CampaignAdminItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ class CampaignAdminItem extends Component {
const badge = {};
const { campaign, item } = this.props;

// @todo customise these status messages for already-published changesets

// Change badge. If the campaign has been published,
// don't apply a badge at all
if (campaign.State === 'open') {
Expand Down
5 changes: 0 additions & 5 deletions src/CampaignAdmin.php
View file
Open in desktop
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ public function getClientConfig()
return array_merge(parent::getClientConfig(), [
'reactRouter' => true,
'form' => [
// TODO Use schemaUrl instead
'EditForm' => [
'schemaUrl' => $this->Link('schema/EditForm')
],
Expand Down Expand Up @@ -601,9 +600,6 @@ public function campaignEditForm($request)
}

/**
* @todo Use GridFieldDetailForm once it can handle structured data and form schemas
* @todo move to FormBuilder
*
* @param int $id
* @return Form
*/
Expand Down Expand Up @@ -684,7 +680,6 @@ public function campaignCreateForm($request)

/**
* Build create form
* @todo Move to form builder
*
* @return Form
*/
Expand Down