Merge pull request #2647 from muskie9/bugfix/virtualPageCanonical2637

UPDATE generate canonical via MetaComponents
silverstripe · May 14, 2021 · f230adc · f230adc
2 parents 4e8c5e6 + 85c3b10
commit f230adc
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/code/Model/VirtualPage.php b/code/Model/VirtualPage.php
@@ -134,23 +134,22 @@ public function ContentSource()
     }
 
     /**
-     * For VirtualPage, add a canonical link tag linking to the original page
-     * See TRAC #6828 & http://support.google.com/webmasters/bin/answer.py?hl=en&answer=139394
-     *
-     * @param boolean $includeTitle Show default <title>-tag, set to false for custom templating
-     * @return string The XHTML metatags
+     * @return array
      */
-    public function MetaTags($includeTitle = true)
+    public function MetaComponents()
     {
-        $tags = parent::MetaTags($includeTitle);
+        $tags = parent::MetaComponents();
+
         $copied = $this->CopyContentFrom();
         if ($copied && $copied->exists()) {
-            $tags .= HTML::createTag('link', [
-                'rel' => 'canonical',
-                'href' => $copied->Link()
-            ]);
-            $tags .= "\n";
+            $tags['canonical'] = [
+                'attributes' => [
+                    'rel' => 'canonical',
+                    'content' => $copied->AbsoluteLink(),
+                ],
+            ];
         }
+
         return $tags;
     }