API Strong typing for the view layer (#1244)

src/Controllers/ElementController.php

@@ -67,10 +67,8 @@ public function getElement()
     /**
      * Renders the managed {@link BaseElement} wrapped with the current
      * {@link ElementController}.
-     *
-     * @return string HTML
      */
-    public function forTemplate()
+    public function forTemplate(): string
     {
         $defaultStyles = $this->config()->get('default_styles');
         $this->extend('updateForTemplateDefaultStyles', $defaultStyles);

src/Models/BaseElement.php

@@ -600,18 +600,16 @@ private function getFieldNamesExcludedFromCmsSearch(): array
      * Default way to render element in templates. Note that all blocks should
      * be rendered through their {@link ElementController} class as this
      * contains the holder styles.
-     *
-     * @return string|null HTML
      */
-    public function forTemplate($holder = true)
+    public function forTemplate($holder = true): string
     {
         $templates = $this->getRenderTemplates();
 
         if ($templates) {
             return $this->renderWith($templates);
         }
 
-        return null;
+        return '';
     }
 
     /**

src/Models/ElementalArea.php

@@ -90,10 +90,7 @@ public function supportedPageTypes()
         return $elementalClasses;
     }
 
-    /**
-     * @return DBHTMLText
-     */
-    public function forTemplate()
+    public function forTemplate(): string
     {
         return $this->renderWith(static::class);
     }

src/ORM/FieldType/DBObjectType.php

@@ -21,7 +21,7 @@ public function __construct()
     /**
      * Add the field to the underlying database.
      */
-    public function requireField()
+    public function requireField(): void
     {
         // noop - This class exists only to bind to a custom GraphQL type
     }