Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are checked on $page->Content: won't work with modules like content blocks #37

Closed
robbieaverill opened this issue Nov 28, 2017 · 2 comments

Comments

@robbieaverill
Copy link

For example if you're using a content blocks module like silverstripe-elemental, you'd want to look at the indexable search data that comes from $page->getElementsForSearch().

In its current configuration the report will not work with modules that change the default content storage location from the Content field to anything else.

An idea for an enhancement here would be to make the HTML search locations configurable.

@robbieaverill
Copy link
Author

This will need more thought, as the page Content field is written back to with broken link classes attached. This would mean we'd need to be inspecting content block content directly, rather than read only versions of it.

@robbieaverill robbieaverill changed the title Links are checked on $page->Content, but could be configurable to look at other fields Links are checked on $page->Content: won't work with modules like content blocks Nov 29, 2017
@brynwhyman
Copy link

Closing this for #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants