Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include broken links from content blocks #68

Open
2 tasks
brynwhyman opened this issue Aug 11, 2020 · 6 comments
Open
2 tasks

Include broken links from content blocks #68

brynwhyman opened this issue Aug 11, 2020 · 6 comments

Comments

@brynwhyman
Copy link

brynwhyman commented Aug 11, 2020

Overview

Currently this report will not include any external broken links that are included in elemental content blocks. As content blocks become a very popular method of creating content, this report should be tracking this content too.

We've seen a similar enhancement (with an open PR) to the elemental content blocks module to ensure that content is being included in the 'Broken page' and 'Broken links' reports, see silverstripe/silverstripe-elemental#689

ACs

  • This looks through every block with a HTML field (including custom blocks)
  • The report should continue to reference the page that includes the content block with the broken link. There is no need to reference the block ID
  • Running the report should result in broken links being highlighted in the WYSIWYG as 'broken'. Note this is existing behaviour for pages, so the aim is to match this functionality.
  • Create a new issue to create a build task to retrospectively find broken links within existing blocks

Notes

PR's

@brynwhyman
Copy link
Author

I still want to check if there's a UI change to broken links in a WYSIWYG after this report is run (i.e. the link is highlighted) as we may need an AC around this.

@robbieaverill
Copy link

Yes, it's supposed to highlight broken links with a red underline

@brynwhyman
Copy link
Author

Thanks @robbieaverill. I've added another AC to reflect this:

  • Running the report should result in broken links being highlighted in the WYSIWYG as 'broken'. Note this is existing behaviour for pages, so the aim is to match this functionality.

@brynwhyman
Copy link
Author

Related/ duplicate: #37

@brynwhyman
Copy link
Author

There's a similar issue which we've previously triaged as a bug: silverstripe/silverstripe-elemental#689

@brynwhyman
Copy link
Author

Noting that a recent bug was raised for CMS job run for this report. This should be reviewed when this issue is picked up: #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants