MINOR: adding SpelledOut method in DBInt #11096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Dec 18, 2023
| @@ -64,7 +64,13 @@ public function Nice() | |||
| { | |||
| return sprintf('%d', $this->value); | |||
| } | |||
|
|
|||
|
|
|||
| public function SpelledOut() | |||
There was a problem hiding this comment.
Please add a phpdoc comment explaining what the method does.
| @@ -64,7 +64,13 @@ public function Nice() | |||
| { | |||
| return sprintf('%d', $this->value); | |||
| } | |||
|
|
|||
|
|
|||
| public function SpelledOut() | |||
There was a problem hiding this comment.
Suggested change
| public function SpelledOut() | |
| public function SpelledOut(): string |
People will expect a string, but NumberFormatter::format() can return false.
This method should return an empty string in the event the format() method returns false.
Comment on lines
+70
to
+71
| $v = $this->prepValueForDB($this->value); | ||
| return (new NumberFormatter(i18n::get_locale(), NumberFormatter::SPELLOUT))->format($v); |
There was a problem hiding this comment.
Suggested change
| $v = $this->prepValueForDB($this->value); | |
| return (new NumberFormatter(i18n::get_locale(), NumberFormatter::SPELLOUT))->format($v); | |
| $value = $this->prepValueForDB($this->value); | |
| $formatter = new NumberFormatter(i18n::get_locale(), NumberFormatter::SPELLOUT); | |
| return $formatter->format($value); |
Please don't use single-letter variables, nor wrap instantiation in quotes.
|
|
||
| public function SpelledOut() | ||
| { | ||
| $v = $this->prepValueForDB($this->value); |
There was a problem hiding this comment.
Why are you calling prepValueForDB() first? e.g. DBInt::Formatted() doesn't do that.
|
Please also create an issue for this PR and link them to each other as per our contribution guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an idea, be curious to see if this would be acceptable.
You can then write in your template:
$MyInt = $MyInt.SpelledOutWhich outputs: