Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make number_format configurable in DBCurrency #9780

Open
wants to merge 1 commit into
base: 4
Choose a base branch
from
Open

Make number_format configurable in DBCurrency #9780

wants to merge 1 commit into from

Conversation

lpostiglione
Copy link

Make number_format configurable (variable naming according to php documentation)

@lpostiglione
Make number_format configurable in DBCurrency
f5d5cf8 
Make number_format configurable (variable naming according to php documentation)
robbieaverill
robbieaverill reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind writing some tests for this?

The changes look good to me. We want to use intl NumberFormatter eventually, but this seems like a reasonable step in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpostiglione @robbieaverill