ENH Add link method to BuildTask #9899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to access dev/tasks from various places in, for example, the CMS. In further commits, this can also be used in other places so that there is one source of truth for the link for a BuildTask.
| */ | ||
| public function Link() : string | ||
| { | ||
| $link = $this->Config()->get('segment'); |
There was a problem hiding this comment.
Suggested change
| $link = $this->Config()->get('segment'); | |
| $link = $this->config()->get('segment'); |
| if (! $link) { | ||
| $link = str_replace('\\', '-', static::class); | ||
| } | ||
| return Director::absoluteUrl('dev/tasks/') . $link; |
There was a problem hiding this comment.
I think the dev/ and tasks/ portions are, in theory, configurable via SilverStripe\Dev\DevelopmentAdmin::registered_controllers so I'm not sure we should be hardcoding it here. To be fair on the other site I haven't seen anyone ever change it.
There might be a way how to get the action (and its url) from the SilverStripe\Dev\TaskRunner controller, using/including the task name.
michalkleiner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to access dev/tasks from various places in, for example, the CMS.
In further commits, this can also be used in other places so that there is one source of truth for the link for a BuildTask.