API New $class arg for DataObjectModel->getModelTypeForField() #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids calling
accessField()
which in turn callsDataObject->obj()
. It isn't directly interested in the actual return value, but rather the type of this return value. Due to the way the ORM and DataObject is built, we can't guarantee lazy evaluation of those return values. Some of them cause database queries. One example here isVersioned->versions()
, which performs in-memory operations on a (lazy)DataList
that turn it into a (concrete)ArrayList
.Performing database queries slows down schema generation, but more importantly the database might not be available when we build the schema as part of a deployment operation (rather than a dev or production environment). For example, when creating a deployment package on CircleCI which then gets transferred to the actual production environment.
Context: #388