Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: custom filter fields #431

Conversation

unclecheese
Copy link

Resolves #406

@unclecheese
Copy link
Author

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Couple of very minor things

@@ -427,6 +432,17 @@ public function setObfuscator(NameObfuscator $obfuscator): CodeGenerationStore
return $this;
}

/**
* If true, s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing some text

* @throws SchemaBuilderException
*/
public function __construct(Field $root, Schema $schema, $fields = Schema::ALL)
public function __construct(Field $root, Schema $schema, $fields = Schema::ALL, $resolveConfig = [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add param types e.g. array $resolveConfig = []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants