Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #556

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/Auth/Handler.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ class Handler
* @config
* @var array
*
* @internal Experimental config:
* @todo Move this to a per-schema configuration and refer to this schema from the current endpoint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #555

* @link https://github.com/silverstripe/silverstripe-graphql/issues/58
* @link https://github.com/silverstripe/silverstripe-graphql/issues/52
* @internal Experimental config
*/
private static $authenticators = [
[
Expand Down
2 changes: 0 additions & 2 deletions src/Middleware/QueryCachingMiddleware.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ protected function getCachedResponse(string $key): ?array

// On cache success validate against cached classes
foreach ($cached['classes'] as $class) {
// Note: Could combine these clases into a UNION to cut down on extravagant queries
// Todo: We can get last-deleted/modified as well for versioned records
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #554

$lastEditedDate = DataObject::get($class)->max('LastEdited');
if (strtotime($lastEditedDate ?? '') > strtotime($cached['date'] ?? '')) {
// class modified, fail validation of cache
Expand Down
2 changes: 0 additions & 2 deletions src/Schema/DataObject/InterfaceBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ public function createInterfaces(ModelType $modelType, array $interfaceStack = [
)
->setTypeResolver([AbstractTypeResolver::class, 'resolveType']);

// TODO: this makes a really good case for
// https://github.com/silverstripe/silverstripe-graphql/issues/364
GuySartorelli marked this conversation as resolved.
Show resolved Hide resolved
$validPlugins = [];
foreach ($modelType->getPlugins() as $name => $config) {
$plugin = $modelType->getPluginRegistry()->getPluginByID($name);
Expand Down