MNT Remove TODO comments #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 19, 2023
sabina-talipova
commented
Oct 19, 2023
src/Services/LDAPService.php
Outdated
| @@ -975,7 +975,7 @@ public function updateLDAPFromMember(Member $member) | |||
| foreach ($member->config()->ldap_field_mappings as $attribute => $field) { | |||
| $relationClass = $member->getRelationClass($field); | |||
| if ($relationClass) { | |||
| // todo no support for writing back relations yet. | |||
| continue; | |||
There was a problem hiding this comment.
GuySartorelli
requested changes
Oct 19, 2023
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
7491c55
to
5119cde
Compare
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
5119cde
to
6da7378
Compare
|
I've created new ticket: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue