Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Replace Extension subclasses #88

Merged
merged 1 commit into from
Aug 28, 2024
Merged

API Replace Extension subclasses #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/en/developer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,9 @@ mentioned above. You will still need to apply that extension to `SilverStripe\Se

```php
use SilverStripe\Assets\Image;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
class MyMemberExtension extends DataExtension
class MyMemberExtension extends Extension
{
private static $db = [
// 'description' is a regular textual field and is written automatically.
Expand Down
6 changes: 3 additions & 3 deletions src/Extensions/LDAPGroupExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\LDAP\Model\LDAPGroupMapping;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
use SilverStripe\ORM\HasManyList;

/**
Expand All @@ -19,9 +19,9 @@
*
* @method HasManyList<LDAPGroupMapping> LDAPGroupMappings()
*
* @extends DataExtension<Group&static>
* @extends Extension<Group&static>
*/
class LDAPGroupExtension extends DataExtension
class LDAPGroupExtension extends Extension
{
/**
* @var array
Expand Down
6 changes: 3 additions & 3 deletions src/Extensions/LDAPMemberExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\Forms\TextField;
use SilverStripe\LDAP\Services\LDAPService;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Core\Extension;
use SilverStripe\ORM\ValidationException;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\Security\Member;
Expand All @@ -19,9 +19,9 @@
*
* Adds mappings from AD attributes to SilverStripe {@link Member} fields.
*
* @extends DataExtension<Member>
* @extends Extension<Member>
*/
class LDAPMemberExtension extends DataExtension
class LDAPMemberExtension extends Extension
{
/**
* @var array
Expand Down
Loading