Add note on re-configuring RealMe module #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module supports re-configuration after initial YML loading for more complex environments - this adds a brief note to the documentation that indicates this and lists what you need to watch out for.
|
Hmmm, unlike SS3, in SS4 modifying config with PHP involves mutating the config manifest and is bad for performance reasons. We shouldn’t really be encouraging it. I see you’ve noted it as a temporary solution until #26 is resolved though so it’s probably OK for now. Also worth noting that _config.php files are run on every request, not just those for RealMe requests |
|
Great point, thanks @robbieaverill! I've updated the docs to reflect this a bit better, and changed the code so it only modifies config if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module supports re-configuration after initial YML loading for more complex environments - this adds a brief note to the documentation that indicates this and lists what you need to watch out for.